Remove Arrow support#53
Merged
estebanzimanyi merged 1 commit intoJul 15, 2026
Merged
Conversation
MobilityDB removed the Arrow C Data Interface export (meos_arrow.h, meos_*_to_arrow / _from_arrow / _arrow_roundtrip). Drop the generator's Arrow-specific machinery accordingly: - the meos_arrow.h -> ARROW family classification; - the ArrowSchema / ArrowArray external-opaque-struct demotion to void * (its only reason to exist was the Arrow structs); - ARROW from the ALL-families build mirror (kept in sync with MobilityDB CMakeLists.txt) and from the family classification tests. The regenerated catalog carries no arrow functions and no ARROW family.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Drops the Arrow-specific machinery from the catalog generator, matching MobilityDB/MobilityDB#1389 which removes the Arrow C Data Interface export (
meos_arrow.h,meos_*_to_arrow/_from_arrow/_arrow_roundtrip). The derivedmeos-idl.jsonthen carries zero arrow surface.The change:
meos_arrow.h→ARROWfamily classification;ArrowSchema/ArrowArrayexternal-opaque-struct demotion tovoid *(its sole purpose is the Arrow C Data Interface structs) and its two call sites;ARROWfrom theALL-families build mirror (in sync with MobilityDBCMakeLists.txt) and from the family-classification tests.Regenerating the catalog from arrow-free MobilityDB master (
6c2420171) yields 0 arrow functions and noARROWfamily.