GEOPY-2919#72
Merged
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR improves octree refinement parameter handling when building OctreeOptions from UI JSON by avoiding propagation of None values for optional refinement fields, allowing RefinementOptions defaults to apply cleanly. It also adds a regression test to cover this UI JSON → params path.
Changes:
- Update
collect_refinements_from_dictto omit refinement fields whose UI-derived values areNone, while still detecting inactive refinements correctly. - Add a test that reads the default octree UI JSON, sets minimal refinement inputs, and validates that refinements are created successfully.
- Ignore a local developer batch file (
devtools/conda_env_pylint.bat) via.gitignore.
Reviewed changes
Copilot reviewed 2 out of 3 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
tests/run_tests/octree_creation/params_test.py |
Adds coverage for building OctreeOptions from UI JSON with a refinement object set. |
grid_apps/octree_creation/options.py |
Ensures refinement dicts don’t include None values so model defaults apply and parsing is more robust. |
.gitignore |
Ignores a local devtools batch file. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
benk-mira
approved these changes
Jun 22, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.