ci: o1js API reference workflow pins Node 16, below both projects' engines - #1215
Open
boleklebovski wants to merge 1 commit into
Open
ci: o1js API reference workflow pins Node 16, below both projects' engines#1215boleklebovski wants to merge 1 commit into
boleklebovski wants to merge 1 commit into
Conversation
Node 16 is below the engines floor of both o1js (>=18.14.0) and this repo (>=22), so the job cannot install either project. Signed-off-by: boleklebovski <160799963+boleklebovski@users.noreply.github.com>
|
@boleklebovski is attempting to deploy a commit to the Mina Foundation's projects Team on Vercel. A member of the Team first needs to authorize it. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
.github/workflows/o1js-api-reference.yml:12sets up Node 16, then runsnpm ci && npm run buildagainst two projects that both require newer:engines.nodeo1-labs/o1js(currently 2.15.0)>=18.14.0docs2)>=22So the job installs a runtime older than either floor and then tries
npm ciin both trees. Node 16 also reached end of life in September 2023.The workflow is
workflow_dispatchonly, so it never blocks a PR — the effect is quieter: regenerating the o1js API reference is broken whenever a maintainer actually reaches for it.Fix
One line:
node-version: 16→node-version: 22. That clears both floors and matches this repo's ownenginesdeclaration. The rest of the workflow is already current (actions/setup-node@v6,actions/checkout@v6).The line carries the comment "In case of version change, update README.md accordingly" — I checked, and the README does not state a Node version anywhere, so there is nothing to keep in sync. Happy to add one if you would like the comment to stay meaningful.
Verification
Workflow re-parsed as YAML after the edit; the
setup-nodestep reads{'node-version': 22}. No other step, trigger or command is touched.