Auth check - #8
Merged
Merged
Conversation
5 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixed the JWT signature verification vulnerability. Here's what changed:
New file: lib/auth/jwt.ts
Server-only utility that verifies JWT HS256 signatures using the Web Crypto API (works in Next.js edge runtime)
Validates alg, exp, and recomputes the HMAC-SHA256 signature with AUTH_SECRET
Throws at runtime if imported from a client component
Updated files:
middleware.ts — now await verifyJwt(token) instead of base64-decoding and trusting exp
app/api/drafts/route.ts — getUserIdFromRequest uses verifyJwt so forged tokens can't write drafts under arbitrary user IDs
app/api/drafts/[id]/route.ts — same fix
lib/auth/ProtectedRoute.tsx — removed local JWT payload decoding; now calls authApi.getCurrentUser() to let the backend verify the session, clearing auth on 401/403
lib/auth/sessionTimeout.ts — added comment clarifying payload decoding is UX-only and not security-critical
Tests added:
lib/auth/jwt.test.ts (7 tests) — covers correct signature, tampered signature, wrong secret, expired token, missing signature, wrong algorithm, and malformed tokens
closes #2