Conversation
Register schemas.MetronInfo.v1_1 as a new SchemaVersion, validated before v1 since the schema is not a strict superset (Genre elements now use resourceType instead of the removed genreType). Rename the v1 schema directory to v1_0 for naming consistency between versions.
Fix _schema_path, which broke when the v1 schema directory was renamed to v1_0, and point it at v1_1 so writes validate against the newer schema. Wire AlternativeNumber to Metadata.alternate_number and CommunityRating to Metadata.community_rating plus a new rating_count field, and update the written XML namespace/schemaLocation to v1.1.
v1.1 is a strict superset of v1.0 (only additive optional elements, plus a Genre type rename to an identical shape), so v1.0 could never be the winning match in the newest-first validation order. Remove the dead METRON_INFO_V1 entry and its schema files.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
AlternativeNumber,CommunityRating) and updateMetronInfoto validate/write against it.AlternativeNumbertoMetadata.alternate_numberandCommunityRatingtoMetadata.community_ratingplus a newMetadata.rating_countfield.xmlns/schemaLocationto point at the v1.1 schema.validate.py/SchemaVersion: v1.1 is a strict superset of v1.0 (only additive optional elements, plus aGenretype rename to an identical shape), so v1.0 could never win in the newest-first validation order — it was dead code.