Skip to content

Compute and output normalized error above tolerance #112

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
stelliom wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Compute and output normalized error above tolerance #112

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 10 additions & 1 deletion engine/check.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -88,10 +88,19 @@ def check(
logger.info("RESULT: check FAILED for %s", current_file)
log_dataframe(logger, "Differences", err, verbose=verbose)
log_dataframe(logger, "\nTolerances", tol, verbose=verbose)

err_rel_tol = compute_division(err, tol)
err_above_tol = (err_rel_tol - 1.).clip(lower=0.)
log_dataframe(
logger,
"\nError relative to tolerance",

@huppd huppd Aug 3, 2026 •
edited
Loading

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
"\nError relative to tolerance",
"\nErrors above tolerance (normalized): max((Differences - Tolerances) / Tolerances, 0)",

compute_division(err, tol),
err_rel_tol,
verbose=verbose,
)
log_dataframe(
logger,
"\nNormalized error above tolerance",
err_above_tol,
verbose=verbose,
)
all_out = False
Expand Down
Loading