fix: remove unused CommandCatalog import - #226
Merged
seankmartin merged 1 commit intoAug 17, 2026
Merged
Conversation
The command catalog is now constructed by the viewer, so default_viewer_setup no longer references CommandCatalog directly. The leftover import fails lint:check with no-unused-vars.
Author
|
@seankmartin Hi Sean, here is a small PR for fixing the failing check in the upstream repo |
|
Thanks! Had removed it locally and didn't realise I hadn't committed it |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes the failing
clientjob on google#1072.lint:checkfails on the current head (f997b259):Since the command catalog is now constructed by the viewer,
default_viewer_setupno longer referencesCommandCatalogdirectly. This removes the leftover import.Verified locally against
f997b259, matching the steps in theclientCI job:npm run format:fix+git diff --exit-code— cleannpm run lint:check— 0 warnings, 0 errorsnpm run typecheck— passnpm test -- --project node— 47 files, 521 tests passed