feat: update tool to be all combined - #219
Merged
seankmartin merged 11 commits intoAug 12, 2026
Merged
Conversation
seankmartin
commented
Aug 12, 2026
seankmartin
commented
- feat: v1 of new tool system
- refactor: move dumped logic in activate into class methods and class state
- feat: update UI with less tools
- feat: add dual mode for split and merge
- fix: block modes at the same time
- refactor: update command naming
- chore: update func to async
- feat: update edit tool behaviour add actions for all skeleton edit buttons add mac specific binds indicate binds on buttons make controls non ambiguous tool banner shows if node from non visible skeleton block true end from being set as root
- refactor: use correct actions pattern following recolor
- fix: set skeleton state watchable
(cherry picked from commit f470be8)
…state (cherry picked from commit 404c165)
(cherry picked from commit 28b61a0)
(cherry picked from commit 1d573ad)
(cherry picked from commit 791922b)
(cherry picked from commit 7cd39be)
(cherry picked from commit bc84758)
add actions for all skeleton edit buttons add mac specific binds indicate binds on buttons make controls non ambiguous tool banner shows if node from non visible skeleton block true end from being set as root (cherry picked from commit 71332b6)
(cherry picked from commit 7d0df5b)
(cherry picked from commit 8a02a19)
seankmartin
commented
Aug 12, 2026
| export function formatKeyStroke(stroke: string) { | ||
| const parts = stroke.split("+"); | ||
| return parts.map(formatKeyName).join("+"); | ||
| const mac = isMacPlatform(); |
Author
There was a problem hiding this comment.
This we can remove, I'd rather we add a PR separately
| // Add the tab navigation map to the viewer's slice and perspective view | ||
| // panels so shortcuts work when the user's focus is on a viewport, not just | ||
| // the sidebar. Scoped to this Tab's lifetime via `this` as the context. | ||
| layer.manager.root.toolBinder.bindInputEventMap( |
Author
There was a problem hiding this comment.
This is a pretty unsafe and non scaling pattern to add the binds, tracking this separately to find something better
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.