feat: two node highlights, one of selected and one of hovered. Color from skeleton for hovered. - #214
Merged
Merged
Conversation
This reverts commit 8c6e5ca.
seankmartin
changed the title
seankmartin
commented
Jul 6, 2026
Author
|
I'll merge since it's mostly rendering but if any comments come up later lmk and happy to address them |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Only note is that the color tests were removed on purpose as I'd rather we focus on tests more around the core behaviour. If a node highlights a bit wrongly that's not the end of the world, and is likely to be caused by something outside of unit tests around the color system anyway.