Pr/apply filter in overview - #314
Draft
HuntTheSun wants to merge 4 commits into
Draft
Conversation
Signed-off-by: HuntTheSun <HuntTheSun@users.noreply.github.com>
Signed-off-by: HuntTheSun <HuntTheSun@users.noreply.github.com>
Signed-off-by: HuntTheSun <HuntTheSun@users.noreply.github.com>
Signed-off-by: HuntTheSun <HuntTheSun@users.noreply.github.com>
Contributor
Author
|
Oh yeah, I forgot to ask: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Implementation of #301
Sorry for the one large commit, my IDE autoformatted a bunch of code, making diffs giant and I only realized it too late.
Do you care about atomic commits for review or do you review all changes in one diff anyway?
Changes made:
I dont know if you want the filter active dot in the topbar, just drop those commits if you dont,
I just added them since I frequently forgot if I had a filter active during testing.
Heres a sample:
apply_overview_filter.html
I hope it isn't too much of a hassle to review :)
Please take your time and let me know if I should change anything.
Thank you!