Skip to content

Force end-of-line#83

Open
MaddTheSane wants to merge 1 commit into
MacPaw:masterfrom
MaddTheSane:eolForce
Open

Force end-of-line#83
MaddTheSane wants to merge 1 commit into
MacPaw:masterfrom
MaddTheSane:eolForce

Conversation

@MaddTheSane

Copy link
Copy Markdown

Force end-of-line on a few files.
Specifically, those that currently end in crlf are marked so.

Also ignore xcuserdata/

Specifically, those that currently end in crlf are marked so.

Also ignore xcuserdata/

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR standardizes line-ending handling by adding .gitattributes rules and re-saving a set of existing source files to align with the intended EOL policy. It also adds a Git ignore rule intended to keep Xcode user-specific state out of the repository.

Changes:

  • Added .gitattributes to normalize text files and explicitly pin EOLs (including eol=crlf for specific existing files).
  • Updated multiple existing source files with no content changes (EOL normalization only).
  • Added .gitignore entry for xcuserdata/.

Reviewed changes

Copilot reviewed 1 out of 22 changed files in this pull request and generated no comments.

Show a summary per file
File Description
WinZipJPEG/JPEG.h No functional changes; EOL normalization.
WinZipJPEG/JPEG.c No functional changes; EOL normalization.
WinZipJPEG/Dependencies No functional changes; EOL normalization.
lzma/Types.h No functional changes; EOL normalization.
lzma/Lzma2Dec.h No functional changes; EOL normalization.
lzma/Lzma2Dec.c No functional changes; EOL normalization.
lzma/BraIA64.c No functional changes; EOL normalization.
lzma/Bra86.c No functional changes; EOL normalization.
lzma/Bra.h No functional changes; EOL normalization.
lzma/Bra.c No functional changes; EOL normalization.
Crypto/des.h No functional changes; EOL normalization.
Crypto/des.c No functional changes; EOL normalization.
Crypto/brg_endian.h No functional changes; EOL normalization.
Crypto/aestab.h No functional changes; EOL normalization.
Crypto/aeskey.c No functional changes; EOL normalization.
Crypto/aescrypt.c No functional changes; EOL normalization.
Crypto/aes.h No functional changes; EOL normalization.
.gitignore Adds ignore rule for xcuserdata/.
.gitattributes Adds repository-wide text normalization and explicit EOL rules for selected files.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@Krivoblotsky

Copy link
Copy Markdown
Contributor

Hi @MaddTheSane — apologies for the silence on this one, it's long overdue for a look.

The .gitattributes additions and CRLF normalization look like a clean housekeeping improvement. We'll review this shortly and get back to you. Thanks for your patience.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants