fix: weapon type detection from cateogories not using the correct names#509
Open
Darxo wants to merge 1 commit into
Open
fix: weapon type detection from cateogories not using the correct names#509Darxo wants to merge 1 commit into
Darxo wants to merge 1 commit into
Conversation
Vanilla uses the weapon names from ::Const.Items.WeaponTypeName in this.m.Categories The only reason that this code worked is, because the keys from ::Const.Items.WeaponType happen to be an exact subset of their respective full names
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Vanilla uses the weapon names from
::Const.Items.WeaponTypeNameinthis.m.CategoriesThe only reason that this code worked is, because the keys from
::Const.Items.WeaponTypehappen to be an exact subset of their respective full namesThe current implementation (before this proposed fix) could cause complications, if a mod chooses to
WeaponTypeName(e.g. translation)this.m.Cateogireswith those new weapon type termsThen MSU would not be able to detect the weapon types anymore, because it looks for the old, english keys from
WeaponType, when it should scan for their human-readable names fromWeaponTypeName