Skip to content

Recover famefield quest descriptions (+ fix Chinese-polluted ko source) - #62

Merged
Zintixx merged 1 commit into
mainfrom
recover-famefield-questdesc
Jul 29, 2026
Merged

Recover famefield quest descriptions (+ fix Chinese-polluted ko source)#62
Zintixx merged 1 commit into
mainfrom
recover-famefield-questdesc

Conversation

@Zintixx

@Zintixx Zintixx commented Jul 28, 2026

Copy link
Copy Markdown
Collaborator

Second recovery of pre-#55 loss (companion to #61). The original XML→JSON dropped questdescription_famefield's 106 entries because of the trailing-space filename bug (fixed in #60), so they never landed in the combined questdescription_final.json.

What this restores

Locale Change
en / cn / jp +106 famefield entries added — real translations (Cry of the Wildflower, The Case of the Missing Plungers, …) that were missing from the client entirely.
ko 106 famefield keys corrected from Chinese → Korean.

The ko finding

The Korean base-language template held Simplified Chinese for all 106 famefield keys — 0 Hangul, 106 Han. When ko's own famefield parse failed on the space bug, the missing-keys merge backfilled the ko template from cn, so Weblate's Korean source for these quests was actually Chinese (e.g. 野花的悲鸣). Corrected to the real KMS2 Korean (야생화의 비명).

Safety

  • No original key dropped, no non-famefield key changed (verified: en/cn/jp are +849/-1 single additive hunks; ko is 425/425 in-place value swaps).
  • Regenerated en XML from the updated JSON: the 106 entries emit valid XML and verify reports 0 structural / 0 key issues.
  • JSON-only PR; the nightly regenerates the XML.

🤖 Generated with Claude Code


View with [code]smith Autofix with [code]smith
Need help on this PR? Tag @codesmith-bot with what you need. Autofix is disabled.

The original XML->JSON dropped questdescription_famefield's 106 entries
because of the trailing-space filename bug (fixed in #60), so they never
made it into the combined questdescription_final.json.

- en/cn/jp: add the 106 missing famefield entries (real translations, e.g.
  'Cry of the Wildflower', 'The Case of the Missing Plungers').
- ko: the base-language template held Chinese for all 106 famefield keys
  (the missing-keys merge backfilled ko from cn when ko's own parse failed).
  Correct them to the real Korean from the KMS2 source (e.g. 野花的悲鸣 -> 야생화의 비명).

No original key dropped, no non-famefield key changed. Verified end-to-end:
json-to-xml regenerates valid XML for the recovered entries and 'verify' passes.

Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
@coderabbitai

coderabbitai Bot commented Jul 28, 2026

Copy link
Copy Markdown

Warning

Review limit reached

@Zintixx, you've reached your PR review limit, so we couldn't start this review.

Next review available in: 20 minutes

Enable usage-based reviews in Billing to review now. Otherwise, wait until the next included review is available.
You're only billed for reviews past your plan's rate limits ($0.25/file).

How can I continue?

After more reviews become available, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews.

How do review limits work?

CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability.

For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window.

Please refer docs for additional details.

Review details
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro Plus

Run ID: d6cb9ebc-6950-4c4f-993b-a6ef499de40c

📥 Commits

Reviewing files that changed from the base of the PR and between 6ff7abf and 4398a93.

📒 Files selected for processing (4)
  • WeblateConverter/Json/cn/questdescription_final.json
  • WeblateConverter/Json/en/questdescription_final.json
  • WeblateConverter/Json/jp/questdescription_final.json
  • WeblateConverter/Json/ko/questdescription_final.json
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch recover-famefield-questdesc

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@Zintixx
Zintixx merged commit a0dda1a into main Jul 29, 2026
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant