Recover famefield quest descriptions (+ fix Chinese-polluted ko source) - #62
Conversation
The original XML->JSON dropped questdescription_famefield's 106 entries because of the trailing-space filename bug (fixed in #60), so they never made it into the combined questdescription_final.json. - en/cn/jp: add the 106 missing famefield entries (real translations, e.g. 'Cry of the Wildflower', 'The Case of the Missing Plungers'). - ko: the base-language template held Chinese for all 106 famefield keys (the missing-keys merge backfilled ko from cn when ko's own parse failed). Correct them to the real Korean from the KMS2 source (e.g. 野花的悲鸣 -> 야생화의 비명). No original key dropped, no non-famefield key changed. Verified end-to-end: json-to-xml regenerates valid XML for the recovered entries and 'verify' passes. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
|
Warning Review limit reached
Next review available in: 20 minutes Enable usage-based reviews in Billing to review now. Otherwise, wait until the next included review is available. How can I continue?After more reviews become available, a review can be triggered using the To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews. How do review limits work?CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability. For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window. Please refer docs for additional details. Review details⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (4)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Second recovery of pre-#55 loss (companion to #61). The original XML→JSON dropped
questdescription_famefield's 106 entries because of the trailing-space filename bug (fixed in #60), so they never landed in the combinedquestdescription_final.json.What this restores
Cry of the Wildflower,The Case of the Missing Plungers, …) that were missing from the client entirely.The ko finding
The Korean base-language template held Simplified Chinese for all 106 famefield keys — 0 Hangul, 106 Han. When ko's own famefield parse failed on the space bug, the missing-keys merge backfilled the ko template from
cn, so Weblate's Korean source for these quests was actually Chinese (e.g.野花的悲鸣). Corrected to the real KMS2 Korean (야생화의 비명).Safety
+849/-1single additive hunks; ko is425/425in-place value swaps).verifyreports 0 structural / 0 key issues.🤖 Generated with Claude Code
Need help on this PR? Tag
@codesmith-botwith what you need. Autofix is disabled.