Read spawner properties off MS2InteractActor entities - #74
Conversation
|
Warning Review limit reached
Next review available in: 48 minutes Enable usage-based reviews in Billing to review now. Otherwise, wait until the next included review is available. How can I continue?After more reviews become available, a review can be triggered using the To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews. How do review limits work?CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability. For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window. Please refer docs for additional details. Review details⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (4)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
.editorconfig declared end_of_line = crlf but there was no .gitattributes, so the stored line endings were mixed: ~27 files CRLF, the other ~790 LF. The Format workflow runs `dotnet format whitespace` on an Ubuntu runner, where the checkout is LF, so it rewrote every LF file to CRLF and git-auto-commit-action pushed a 790-file "style: auto-format whitespace" commit onto every pull request. #74 is the most recent victim. Add .gitattributes with `* text=auto eol=lf` and switch .editorconfig to lf so both agree and every checkout - Windows or Linux - sees the same endings. The one-time `git add --renormalize` converts the 27 CRLF stragglers; the change is line endings only.
A handful of MS2InteractActor entities double as NPC spawn points and carry the SpawnPointNPC property set (SpawnPointID / SpawnRadius / NpcCount / NpcList) on the entity itself. Neither the flat definition nor any mixin declares those properties, so XBlockParser hit a null FlatProperty and discarded every one of them. MS2Actor already had the same treatment: the properties are declared on the interface and patched into the type index by RuntimeClassLookup's manual override block. MS2InteractActor never got it. Mirror that here. A sweep over every xblock finds exactly one such entity today: 11000119_MS2InteractActor_Moonrabbit on 80000022_bonus, which is both the Moonrabbit mortar interact object and the spawn point for the Moon Bunny (27000036). Refs MS2Community/PrivateMaple2#270
cf61c66 to
ef918e9
Compare
1 participant
Some
MS2InteractActorentities double as NPC spawn points and carry theSpawnPointNPCproperty set (SpawnPointID,SpawnRadius,NpcCount,NpcList) directly on the entity. Neither the flat definition nor any mixin declares those properties, soXBlockParser.GetInstancegot a nullFlatPropertyback frombaseType.GetProperty(...), logged "Ignoring unknown property", and dropped them.MS2Actoralready has exactly this workaround: the properties are declared onIMS2Actor(tagged[Obsolete("This property should not exist")]) and patched into the type index by the "Manual index overrides" block inRuntimeClassLookup.MS2InteractActornever got the same treatment. This mirrors it.ProxyNifAssetandreactableSequenceNamewere already reachable (viaI3DProxyandIMS2InteractActorrespectively), so only the four spawner properties are added.Scope
A sweep over every xblock in the game finds exactly one entity that carries this data:
It is both the Moonrabbit mortar interact object and the spawn point for the Moon Bunny (27000036). The interactobject table entry for 11000119 has an empty
<spawn code="" radius="" count="" prop="" lifeTime="" />, so the entity really is the only place this data exists.InteractActorSpawnerTestasserts the Moonrabbit entity parses with its spawner data, and carries an opt-in diagnostic sweep that prints every such entity game-wide.Notes
PackageVersionbumped to 2.4.17. Merging this publishes the package.Refs MS2Community/PrivateMaple2#270