Add subgrid cases to hurricane test group#967
Draft
bmooremaley wants to merge 61 commits into
Draft
Conversation
- Commented out
- Add ability to limit minimum depth outside of floodplain - Assign remaped bathymetry to bottomDepthObserved variable
- Still needed in base mesh for specifying coastal resolution
- Add modeled vs. observed high water scatter plot - Add spatial high water error plot - Add mean sea level adjustment for observations - Allow additional runs to be added in config file
- This was down to .6 km
- New function for hurricane/forward/analysis hwm comparison plots - Removed ocean_subgrid_final.nc naming from hurricane/init - Removed "mode" attribute from hurricane/forward/streams.ocean - Fixed xtime encoding and lat dimensions in hurricane/init/interpolate_atm_forcing.py - Increased init_min_tasks to 512 for devr45to5rr1 mesh - Added mosaic support
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This merge expands the
subgridcapability implemented in theparabolic_bowlandbuttermilk_baytest groups to include thehurricanetest group. In the subgrid case, a volume correction based on subgrid-scale topography is applied to layer thickness in a barotropic configuration, improving coastal and flooding dynamics (Kennedy et al., 2019 Ocean Model.). New features include support for aDEVR45to5rr1mesh, new floodplain culling using geojson, processing of the subgrid DEM and LULC tiles, and new tidal analysis.This branch has been rebased onto 9d775f2. A corresponding E3SM PR will be referenced here once submitted.
Checklist
api.rst) has any new or modified class, method and/or functions listedE3SM-Projectsubmodule has been updated with relevant E3SM changesTestingin this PR) any testing that was used to verify the changes