Rnc/pr edits to zk tars refactor#14
Open
chandrarn wants to merge 2 commits into
Open
Conversation
…ry small modification to .pre-commit-config.yaml to prevent uv synch checks from blocking push, necessary to deal with different OFT install methods
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Small corrections to PR#13, I figured I'd just fix them myself and save you the trouble:
There were a few small errors in pytest: considering the case which neither the TCV nor DIII-D equilibria is available for a user to test, more robust protection for only creating one
oft_envobject, and changing the wayresistivity_listwithingen_OFT_filament_and_eta_fileis handled (modern OFT introduces breaking changes disallowing more resistive elements than mesh "groups" present in the.h5file. The script currently implicitly assumed that you needed one resistivity value per filament. The changes do not impact legacy OFT versions).