UI: modernize managed-record controls, headers, and spacing - #757
Merged
Conversation
…r primitives Move the last hand-rolled tile and section headers onto TileHeader and SectionHeading so every card speaks one header language: the vorsorge dashboard tile, the three illness cards, the metric-correlation section, and the custom-metric list group. The mood-chart title drops to the primitive semibold weight and its bucket label becomes a TagChip. Align the in-card sub-headings of the integration cards to the one sanctioned section-label tier (muted uppercase eyebrow) instead of a second text-sm font-semibold dialect. Keep the onboarding and mental-health wizard hero H1s at their deliberate semibold weight, now marked inline as an intentional exception so a future heading sweep leaves them alone.
Sweep the spacing rests that sat off the 1/1.5/2/3/4/6/8/10 scale: the health-score panels and their skeleton, the recommendation ask-Coach gutter, the onboarding tour footer, the vaccination row, the danger-zone alert margins, the recovery-codes action wrapper, and the chart-tooltip tile. Move the last hand-written micro-sizes (coach counters, the personal-record badge, the score-ring label, the dose-history and cycle-calendar headers, the mood tag chips) onto the text-2xs token, and give the documents upload buttons the mobile tap floor their peers set.
…h primitives Bring the remaining settings and dashboard surfaces onto the shared anatomy: the API and MCP revoke buttons become the destructive variant instead of an outline hand-tinted red; the runtime-actions row places its raw-data setting and status lines above the actions, not under them; the account section paints its card and header while loading instead of a lone spinner; the share revoke becomes a right-aligned row action rather than a full-width alarm strip per link; the recent-workouts tile and the MCP and notifications empty states compose Card and EmptyState instead of hand-rolled bg-card shells.
… shells The shell check caught only the bare `5` step on p/px/py/space-y/gap, so off-scale directional and half-step spacing (`ml-5`, `pl-5`, `gap-3.5`, `py-2.5`, the `7` step) slipped through on hand-rolled card shells. Widen it to the whole spacing prefix family (padding, margin, gap, space) and every banned step — `5`, `7`, and half-steps other than the sanctioned `1.5`. Height stays out of scope: it is a dimension, not a scale step. Verified the rule bites by injecting `gap-3.5` onto a real bg-card+border shell and watching lint flag it, then reverting; the sweep this rule guards left the tree clean apart from one tooltip shell, now on-scale.
…imitives The delegated-caregiver settings forms were the last hand-rolled control block: native <input>/<select> with a copied border literal, a native type=date for the birth date (the browser-locale trap closed for the owner surface in v1.25.4), module checkboxes where the owner section shows switches, and a save button mid-form with the error line dropped below it. Route them through Input, NativeSelect, DateField, and Switch, and give every form a shared footer that places the error line above the action row and the action row last (§12). The Switch rows keep a hidden mirror input so the FormData submit contract is unchanged. Extend the section tests to hold the DateField primitive and the action-last order in place.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The rest of the app-wide UI audit. The managed-record settings move onto the shared primitives (a proper date field instead of a native picker, the same inputs, selects and switches the owner section uses, the error line above the actions). A batch of hand-rolled card headers route through the shared header primitives, and off-scale spacing and micro-labels come onto the scale. The spacing lint now catches the whole off-scale step family across padding, margin and gap.
No behaviour change: only client components, pages, the lint plugin and comments. No server, route, schema or query change.
Full detail in the CHANGELOG.