feat: support strict URL-encoded form transport - #128
Conversation
|
@LuvDaSun could you please review this strict URL-encoded transport change? It is required to safely deliver typed OIDC logout form bodies through generated clients and servers. All 18 local tests and the repository spelling gate pass. |
elmerbulthuis
left a comment
elmerbulthuis
left a comment
There was a problem hiding this comment.
If the purpose of this PR is to support form encoding (which is a very good thing to have), then is should support this in both request and response and it should not touch anything else.
If this (form encoding) is a desired feature, then please make a request for it via issues!
There was a problem hiding this comment.
Please do not introduce new repository structures if not needed, this should be tested differently. Following the structure in place.
| throw new UrlEncodedFormError("URL-encoded form contains invalid percent encoding"); | ||
| } | ||
| try { | ||
| return decodeURIComponent(value.replaceAll("+", " ")); |
| for F in $(ls fixtures/specifications/*.yaml); do | ||
| echo $(basename $F .yaml) | ||
|
|
||
| REQUEST_TYPES="" |
There was a problem hiding this comment.
should be handled differntly, form encoding should be one of the defaults
2 participants
Summary
Verification
Release order
Publish @skiffa/lib 0.14.6 before @skiffa/generator 0.14.2.