Fix light rendering of grids and Settings dialog in dark mode#650
Merged
Conversation
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Dark mode (
Application.SetColorMode) remapsSystemColors, but anything painted by the Windows visual-style renderer only exists in a light flavor. Two symptoms of that plus some hardcoded light-mode colors:EnableHeadersVisualStyleswas left at its default. NewPaintHelper.ApplyGridViewThemedisables it in dark mode; wired viaPaintHelper.SetColumnizerso all grids get it (main, filter, Bookmark window, Pattern window), plus the three grids in the Settings dialog.UseVisualStyleBackColor = truepaints the page body light while child controls inherit the dark ambient color. NewPaintHelper.ApplyTabControlThemeflips it off in dark mode.GetDataGridViewCellStylehad white-on-whiteForeColor. All PaintHelper color helpers now take an explicitdarkModeparameter (call sites passApplication.IsDarkModeEnabled), keeping them pure and unit-testable.18 new tests in
PaintHelperTests. Light-mode behavior unchanged.