fix: table styling#7712
Open
fikrydev wants to merge 2 commits into
Open
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR updates common SCSS styling to (1) remove reliance on the client-js class for collapsible behaviors and (2) adjust table border rendering by adding border-collapse: collapse.
Changes:
- Added a global
border-collapse: collapserule intended to prevent “double/thick” table borders. - Removed
html.client-jsgating from Prizepooltable collapsed-row hiding rules. - Removed
html.client-jsgating from NavFrame and generic.collapsiblecollapsed-content hiding rules.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 4 comments.
| File | Description |
|---|---|
| stylesheets/commons/Tables.scss | Adds border-collapse: collapse rule for tables/wikitables. |
| stylesheets/commons/Prizepooltable.scss | Changes collapsed-row hiding selector from html.client-js to html. |
| stylesheets/commons/NavFrame.scss | Changes NavFrame/collapsible collapsed-content hiding selectors from html.client-js to html. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
|
|
||
| @for $i from 0 through 32 { | ||
| html.client-js .prizepooltable.collapsed[ data-cutafter="#{$i}" ] tr:nth-child( n + #{ $i + 3 } ) { | ||
| html .prizepooltable.collapsed[ data-cutafter="#{$i}" ] tr:nth-child( n + #{ $i + 3 } ) { |
| } | ||
|
|
||
| html.client-js .NavFrame.collapsed .NavContent { | ||
| html .NavFrame.collapsed .NavContent { |
Comment on lines
+77
to
+81
| html .collapsible.collapsed > thead > tr:nth-child( n+2 ), | ||
| html .collapsible.collapsed > thead + tbody, | ||
| html .collapsible.collapsed > tbody > tr:nth-child( n+2 ), | ||
| html .collapsible.collapsed > tfoot, | ||
| html .collapsible.collapsed > tr:nth-child( n+2 ) { |
Comment on lines
+247
to
+250
| table, | ||
| .wikitable { | ||
| border-collapse: collapse; | ||
| } |
Collaborator
|
as copilot already mentioned |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
On Lighthouse the
.client-jsclass is missing (i am not sure about the significance), so this PR removes it and make it so that the styles is deteced by lighthouse. Also it adds aborder-collapsestyling so that the table doesnt have a thick border.How did you test this change?
I removed
.client-json the production wiki by overriding the style and it works.