chore: replace btn with button#7685
Open
fikrydev wants to merge 8 commits into
Open
Conversation
Rathoz
reviewed
Jun 22, 2026
Collaborator
|
imo it's better to keep |
Contributor
Author
|
fikrydev
force-pushed
the
chore/replace-btn-with-button
branch
from
f117de4 to
0504dcf
Compare
Contributor
There was a problem hiding this comment.
Pull request overview
This PR standardizes UI “button” styling hooks by replacing legacy btn* class usage with button* class names across Lua widgets, JavaScript UI code, and SCSS selectors.
Changes:
- Renamed base/variant/size classes from
btn,btn-secondary,btn-small, etc. tobutton,button--secondary,button--small, etc. - Updated SCSS selectors referencing
btn*classes to the newbutton*names. - Updated Lua spec expectations to match the new class names.
Reviewed changes
Copilot reviewed 13 out of 27 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| stylesheets/commons/Match.scss | Updates match page styling selectors from .btn to .button. |
| stylesheets/commons/Mainpage.scss | Updates mainpage countdown selector from .btn-secondary to .button--secondary. |
| lua/wikis/commons/Widget/Match/VodsDropdownButton.lua | Renames the “active” class for the VODs toggle button (but currently introduces a typo). |
| lua/wikis/commons/Widget/Basic/Button.lua | Renames all generated button classes from btn* to button*. |
| lua/wikis/commons/MatchTicker/DisplayComponents.lua | Updates generated matchpage icon classes to the new button* names. |
| lua/wikis/ageofempires/ParticipantTable/Custom.lua | Updates participant table toggle button classes to the new button* names. |
| lua/spec/dropdown_spec.lua | Updates dropdown tests to assert new button* class names. |
| javascript/commons/Slider.js | Updates slider navigation control classes to the new button* names. |
| javascript/commons/Selectall.js | Updates “Select” / “Select and copy” button classes to the new button* names. |
| javascript/commons/Miscellaneous.js | Updates teamcard toggle button classes to the new button* names. |
| javascript/commons/ExportImage.js | Updates dropdown widget toggle button classes to the new button* names. |
| javascript/commons/Commons_tools.js | Updates dynamically injected form button classes to the new button* names. |
| javascript/commons/Collapse.js | Updates collapse UI button classes and selector queries from .btn to .button. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
…/Lua-Modules into chore/replace-btn-with-button
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
Rathoz
reviewed
Jul 1, 2026
Collaborator
There was a problem hiding this comment.
Is there a pending lakeside MR? Otherwise this is a bug
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Remove any usage of btn with button in the repo.
How did you test this change?