feat(match2): add Global Bans to brawlstars#7679
Open
knxd3r wants to merge 6 commits into
Open
Conversation
Adding global bans
hjpalpha
requested changes
Jun 20, 2026
Collaborator
|
how i would do it: |
Co-authored-by: hjpalpha <75081997+hjpalpha@users.noreply.github.com>
hjpalpha
reviewed
Jun 20, 2026
Co-authored-by: hjpalpha <75081997+hjpalpha@users.noreply.github.com>
hjpalpha
approved these changes
Jun 20, 2026
Contributor
Can you also please move MVP like on photo?
|
ElectricalBoy
changed the title
PolandBot
suggested changes
Jun 27, 2026
PolandBot
left a comment
PolandBot
left a comment
Contributor
There was a problem hiding this comment.
I wanna change order a bit
PolandBot
suggested changes
Jun 27, 2026
ElectricalBoy
left a comment
ElectricalBoy
left a comment
Collaborator
There was a problem hiding this comment.
should check compat with other wikis that use CharacterBanTable
(I don't think there's going to be an issue, but still better safe than sorry)
Contributor
There was a problem hiding this comment.
Pull request overview
Adds support for displaying global bans in Brawl Stars match summaries by extending the bans data model to allow custom row labels and by parsing match-level ban inputs into match extradata.
Changes:
- Extended the shared
CharacterBanTablewidget to support an optional per-rowlabel. - Updated Brawl Stars
MatchSummaryto prepend a “Global Bans” row (when present) and to label per-game bans rows using the actual game index. - Updated Brawl Stars match input parsing to read match-level bans into
match.extradata.globalbansand refactored per-map bans parsing to reuse a helper.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| lua/wikis/commons/Widget/Match/Summary/CharacterBanTable.lua | Adds optional label support for bans rows so callers can control the displayed row title. |
| lua/wikis/brawlstars/MatchSummary.lua | Builds bans rows including an optional “Global Bans” entry and switches to Module:Widget/Html directly. |
| lua/wikis/brawlstars/MatchGroup/Input/Custom.lua | Parses match-level bans into globalbans and refactors bans parsing into a shared helper used for map extradata too. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Comment on lines
104
to
108
| return { | ||
| mapveto = MatchGroupInputUtil.getMapVeto(match), | ||
| mvp = MatchGroupInputUtil.readMvp(match, opponents), | ||
| globalbans = getBans(match, #opponents), | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adding global bans
Summary
How did you test this change?
dev
https://liquipedia.net/brawlstars/User:Knoxider/ME_Gaming/49