Skip to content

refactor: extract placement styles to separate stylesheet#7665

Open
ElectricalBoy wants to merge 3 commits into
mainfrom
placement-box-nowrap
Open

refactor: extract placement styles to separate stylesheet#7665
ElectricalBoy wants to merge 3 commits into
mainfrom
placement-box-nowrap

Conversation

@ElectricalBoy

Copy link
Copy Markdown
Collaborator

Summary

This PR:

How did you test this change?

local compilation + difftools

@ElectricalBoy ElectricalBoy requested review from a team as code owners June 16, 2026 01:34
@ElectricalBoy ElectricalBoy added the stylesheets Changes to stylesheets label Jun 16, 2026
@ElectricalBoy ElectricalBoy requested a review from liquidely June 16, 2026 01:35

@hjpalpha hjpalpha left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

seems reasonable on phone

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Refactors placement-number styling by moving it out of the general “Miscellaneous” stylesheet into a dedicated Placement stylesheet, and updates the Sass implementation to avoid deprecated length() / nth() usage while keeping theme-specific colors.

Changes:

  • Added a new stylesheets/commons/Placement.scss containing placement box/text styles and placement color rules.
  • Wired the new stylesheet into the build by adding @use "commons/Placement"; in stylesheets/Main.scss.
  • Removed the previous placement styling block from stylesheets/commons/Miscellaneous.scss.

Reviewed changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.

File Description
stylesheets/Main.scss Imports the new placement stylesheet so the extracted rules are included in the main build.
stylesheets/commons/Placement.scss New dedicated stylesheet for placement text/box styles and theme-aware placement colors.
stylesheets/commons/Miscellaneous.scss Removes the extracted placement styling block to avoid duplication and reduce misc stylesheet scope.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@ElectricalBoy ElectricalBoy requested a review from Rathoz July 1, 2026 14:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

stylesheets Changes to stylesheets

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants