refactor: extract placement styles to separate stylesheet#7665
Open
ElectricalBoy wants to merge 3 commits into
Open
refactor: extract placement styles to separate stylesheet#7665ElectricalBoy wants to merge 3 commits into
ElectricalBoy wants to merge 3 commits into
Conversation
hjpalpha
approved these changes
Jun 16, 2026
hjpalpha
left a comment
Collaborator
There was a problem hiding this comment.
seems reasonable on phone
Contributor
There was a problem hiding this comment.
Pull request overview
Refactors placement-number styling by moving it out of the general “Miscellaneous” stylesheet into a dedicated Placement stylesheet, and updates the Sass implementation to avoid deprecated length() / nth() usage while keeping theme-specific colors.
Changes:
- Added a new
stylesheets/commons/Placement.scsscontaining placement box/text styles and placement color rules. - Wired the new stylesheet into the build by adding
@use "commons/Placement";instylesheets/Main.scss. - Removed the previous placement styling block from
stylesheets/commons/Miscellaneous.scss.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| stylesheets/Main.scss | Imports the new placement stylesheet so the extracted rules are included in the main build. |
| stylesheets/commons/Placement.scss | New dedicated stylesheet for placement text/box styles and theme-aware placement colors. |
| stylesheets/commons/Miscellaneous.scss | Removes the extracted placement styling block to avoid duplication and reduce misc stylesheet scope. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR:
length()andnth()scss functionsHow did you test this change?
local compilation + difftools