refactor: filter buttons to widget3#7585
Merged
Merged
Conversation
ElectricalBoy
force-pushed
the
filterbuttons-widget3
branch
from
1cf0b90 to
f789644
Compare
hjpalpha
approved these changes
Jun 25, 2026
Contributor
There was a problem hiding this comment.
Pull request overview
This PR refactors the FilterButtons widgets from the legacy Widget2 class style to Widget3 functional components, while also switching HTML imports from the deprecated Module:Widget/Html/All to Module:Widget/Html.
Changes:
- Converted
FilterButtons,FilterButtons/Button, andFilterButtons/ButtonRowfromClass.new(Widget)widgets toComponent.component(...)functional components. - Replaced
Module:Widget/Html/Allusage withModule:Widget/Htmltag components. - Adjusted
FilterButton.displayto acceptRenderable|Renderable[]and pass it through aschildrenwithout forcing an extra wrapping layer.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| lua/wikis/commons/Widget/FilterButtons/ButtonRow.lua | Refactors ButtonRow to a Widget3 component and updates HTML tag usage. |
| lua/wikis/commons/Widget/FilterButtons/Button.lua | Refactors Button to a Widget3 component and broadens display to support multiple renderables. |
| lua/wikis/commons/Widget/FilterButtons.lua | Refactors the top-level FilterButtons widget into a Widget3 component entrypoint while keeping helper functions internal. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Rathoz
approved these changes
Jul 1, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
How did you test this change?
trivial