Conversation
Added setup and check steps for LuaLS in the workflow.
Added 'busted' as a dependency for Lua testing.
Set environment variable for LuaLS check.
Removed comment about CI from workspace.library.
Removed the configpath option from LuaLS check command.
Removed installation of 'busted' from dependencies setup.
Removed unused library paths from workspace.library and workspace.ignoreDir.
Add artifact upload step for LuaLS report on failure
Collaborator
Author
|
Debugging Github Workflows is so much fun 🙃 |
mbergen
commented
Apr 4, 2026
Rathoz
approved these changes
Jul 1, 2026
Rathoz
reviewed
Jul 1, 2026
Contributor
There was a problem hiding this comment.
Pull request overview
This PR integrates LuaLS (lua-language-server --check) into the existing CI workflow to surface type/annotation-related diagnostics during pull request validation, with the intent to only report diagnostics for Lua files changed by the PR.
Changes:
- Adds a new
luals-code-stylejob to.github/workflows/luacheck.yml. - Detects changed Lua files in
lua/wikis/**/*.luausingtj-actions/changed-files. - Downloads LuaLS and runs
lua-language-server --checkin CI, emitting a step summary.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Uses LuaLS'
--checkto check for type errors wrt to annotations in CI.Only report errors in lua files changed in a PR.
How did you test this change?
Self-tested in actions:
https://github.com/Liquipedia/Lua-Modules/actions/runs/23975512581/job/69931841239?pr=7112