fix: address Copilot review comments on PR #3428 - #9
Closed
cw20050111-prog wants to merge 1 commit into
Closed
Conversation
- Rename misleading test case ack_bit_is_rdma_ok -> ack_bit_is_urma_ok - Derive URMA recv block size from sizeof(butil::IOBuf::Block) instead of the hard-coded 32-byte constant, which silently assumed the internal Block layout - Pin the umdk WORKSPACE/MODULE.bazel dependency to an immutable commit SHA instead of the movable tag v26.06.0_CAM, matching how every other git dependency in these files is already pinned
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Target
Base branch: LinQuickDev/brpc:urma_transport
Validation