[CCUBE-2268][GZ] wait for filter checkbox item animation - #1402
Open
ghazwan-gt wants to merge 1 commit into
Open
[CCUBE-2268][GZ] wait for filter checkbox item animation#1402ghazwan-gt wants to merge 1 commit into
ghazwan-gt wants to merge 1 commit into
Conversation
ghazwan-gt
marked this pull request as ready for review
August 7, 2026 11:05
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Type of changes
Description of changes
The
FilterItemcomponent usesreact-springto animate expandable container height based onuseResizeDetector. On mount in mobile mode, a cascade occurs. The currentwaitForAnimationEndcan pass before the cascade finishes. When this happens, the screenshot captures a mid-animation state, producing the pixel diffs.The fix is to wait until the cascades flushed, then recheck the element stability.
Checklist
Screenshots