[CCUBE-2216][RYN] exclude undefined selectedIds from Select All check… - #1386
Open
ryan-nguyen-t wants to merge 1 commit into
Open
[CCUBE-2216][RYN] exclude undefined selectedIds from Select All check…#1386ryan-nguyen-t wants to merge 1 commit into
ryan-nguyen-t wants to merge 1 commit into
Conversation
ryan-nguyen-t
marked this pull request as ready for review
August 5, 2026 08:20
ziggyzet
previously approved these changes
Aug 5, 2026
ghazwan-gt
reviewed
Aug 5, 2026
| @@ -32,7 +32,8 @@ const DATA: ApiTableSectionProps[] = [ | |||
| }, | |||
| { | |||
| name: "selectedIds", | |||
| description: "The ids of selected items", | |||
| description: | |||
| "The ids of selected items. If undefined, the Select All checkbox remains enabled when rows are non-empty", | |||
Contributor
There was a problem hiding this comment.
Update the props comment also
…box disabled condition
ryan-nguyen-t
force-pushed
the
CCUBE-2216
branch
from
August 7, 2026 07:34
a5763ea to
2cfe703
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Type of changes
Description of changes
Checklist