[CCUBE-2251][RYN] remove fixed height for buttons - #1377
Open
ryan-nguyen-t wants to merge 14 commits into
Open
Conversation
ryan-nguyen-t
marked this pull request as ready for review
July 30, 2026 07:21
ziggyzet
reviewed
Jul 30, 2026
| }); | ||
|
|
||
| // ------------------------------------------------------------------------- | ||
| // Large font size (accessibility) |
| }); | ||
|
|
||
| // ------------------------------------------------------------------------- | ||
| // Large font size (accessibility) |
| }); | ||
|
|
||
| // ------------------------------------------------------------------------- | ||
| // Large font size (accessibility) |
qroll
requested changes
Jul 30, 2026
qroll
requested changes
Aug 5, 2026
Contributor
|
request: I'm seeing a bunch of button screenshots being updated although they have no visible changes. could you discard those and only commit the new snapshots and snapshots with actual changes? |
Contributor
|
many of the snapshots are still failing. in the case of smart app banner, it's expected as the old height (38px) was incorrect, so the screenshot can be generated. what about the other cases? |
ryan-nguyen-t
force-pushed
the
CCUBE-2251
branch
from
August 6, 2026 08:35
bfaadce to
7a9a7df
Compare
qroll
requested changes
Aug 7, 2026
Comment on lines
+157
to
+158
| padding: calc(${Spacing["spacing-8"]} - ${Border["width-010"]}) | ||
| ${Spacing["spacing-16"]}; |
Contributor
There was a problem hiding this comment.
icon is square so the horizontal and vertical padding would be consistent
Suggested change
| padding: calc(${Spacing["spacing-8"]} - ${Border["width-010"]}) | |
| ${Spacing["spacing-16"]}; | |
| padding: calc(${Spacing["spacing-8"]} - ${Border["width-010"]}); |
| min-height: 4rem; | ||
| `; | ||
|
|
||
| export const mainIconOnly = css` |
Contributor
There was a problem hiding this comment.
reorder so that this is below mainIconPositionRight
| ? clsx( | ||
| sizeClassMap[sizeType]?.base, | ||
| sizeClassMap[sizeType]?.iconOnly, | ||
| styles.mainIconOnly |
| @@ -17,8 +17,7 @@ export const main = css` | |||
| `; | |||
|
|
|||
| export const mainSizeSmall = css` | |||
| height: 2.5rem; | |||
| min-height: unset; | |||
| min-height: 2.5rem; | |||
Contributor
There was a problem hiding this comment.
for singpass button, can we also apply the same padding to compensate?
padding: calc(${Spacing["spacing-8"]} - ${Border["width-010"]})
${Spacing["spacing-16"]};
Contributor
There was a problem hiding this comment.
for smart app banner, should clean up the height: auto style
Contributor
There was a problem hiding this comment.
same here, let's clean up the height: auto style in toast
Contributor
There was a problem hiding this comment.
filter had custom styles for the buttons. can you check and reconcile the expected behaviour?
added 13 commits
August 7, 2026 12:44
ryan-nguyen-t
force-pushed
the
CCUBE-2251
branch
from
August 7, 2026 05:45
7bfe736 to
d87129f
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Type of changes
Description of changes
Checklist