fix(calendar): require semester for subscription set#9
Merged
Conversation
tiankaima
marked this pull request as ready for review
July 15, 2026 16:15
This was referenced Jul 15, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Goal
Prevent
calendar setfrom issuing an unscoped subscription replacement. This command was the destructive call in the July 10 automated CLI sweep tracked in Life-USTC/server#431.Changed Surfaces
--semester-idforworkspace calendar setbefore credentials or network access.Evidence
go test ./...go vet ./...go build -buildvcs=false ./...Docs / Contracts
No CLI contract change. The companion server PR rejects unscoped batch
action=setrequests.Risk Areas
Explicit unscoped
calendar setcalls now fail locally and must name the semester being replaced. Add/remove/query/import behavior is unchanged.Cleanup
No generated files, scratch artifacts, or unrelated rewrites.