fix(sync): preserve subscriptions from other semesters#8
Merged
Conversation
Member
Author
|
CI exposed that |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Root cause
school synccombined all matched sections into one globalaction=setrequest. The server historically interpreted that request as replacing every subscribed section, so syncing a subset of semesters could erase historical subscriptions used by Dashboard, Bot schedules, homework history, and iCalendar.This is the CLI side of Life-USTC/server#431 and depends on the semester-scoped server behavior in Life-USTC/server#434.
Changes
action=setrequest per semester withsemesterIdpopulated.Validation
gofmtgo test ./...