feat: use generated client for subscription APIs#3
Merged
Conversation
- Preserve computed audience fallback in verifiedTokenToCredential on refresh. - Remove dead code: credentialFromTokens, requiredString, strDefault, jsonValid. - Reject empty issuer/audience in ValidateIDToken instead of skipping checks. - Use strconv.ParseInt in parseIntString. - Trim server consistently in RefreshToken and document resource refresh regression.
…d_token for openid scope - Pass registered clientID (not server URL) as audience to ValidateIDToken in Login, RefreshToken, and LoginDeviceCode. - Keep Credential.Resource as the server URL/resource indicator; verifiedTokenToCredential now accepts resource separately. - Return an error when openid scope was requested but the token response lacks id_token. - Add nil guard for VerifiedToken in verifiedTokenToCredential. - Document ExpiresAt - 1h heuristic in RefreshToken. - Add unit tests for audience validation, nil guard, and missing id_token.
- todo done: call PATCH /api/todos/batch instead of looping single updates - homework done: call PUT /api/homeworks/completions instead of looping - comment delete: call DELETE /api/comments/batch instead of looping - calendar: add import-codes command using POST /api/calendar-subscriptions/import-codes - preserve interactive single-pick flows and per-item success reporting - report partial batch failures as a single returned error Task: 17
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
feature:read/feature:writeform, e.g.todo:read,todo:write)Verification
make check-openapi-syncgo test ./...go build ./...Depends on Life-USTC/server#320 for the new generated subscription endpoints.