Added Firmware Updates, Parameter Get/Fetch, Terminal use and other minor updates#38
Open
lukedempsey wants to merge 3 commits into
Open
Added Firmware Updates, Parameter Get/Fetch, Terminal use and other minor updates#38lukedempsey wants to merge 3 commits into
lukedempsey wants to merge 3 commits into
Conversation
Allow firmware updates and parameter configuration
Owner
|
Hi Luke. Sorry for not seeing this sooner. Could you address the merge conflicts? |
Jotham-B
pushed a commit
to moltenmosfet/PyVESC
that referenced
this pull request
Jul 4, 2026
…re flashing, params Resolves the modify/delete conflicts by porting master's changes into the PR's flattened layout (pyvesc/VESC.py + pyvesc/messages/): - multi-CAN-ID heartbeat (PR LiamBindle#37): alive message list, start_heartbeat(can_id=) - **kwargs (can_id) passthrough on set_rpm/set_current/set_duty_cycle/set_servo - COMM_FORWARD_CAN = 34 (verified against current vedderb/bldc datatypes.h) - drop module-level alive_msg from setters Fixes on top of the PR: - restore the public API (pyvesc.encode/decode/messages/VESC) gutted by the emptied __init__.py files; simple.py and docs autoclass refs work again - decode(): skip unparseable garbage instead of TypeError/infinite loop; forward recv= to VESCMessage.unpack - move dummy test-message IDs to 0xE0+ so they don't collide with real registered commands; all 9 tests + params self-tests pass - setup.py: package list for the new layout, python_requires>=3.6 - update examples/docs for scalar'd SetDutyCycle (fraction) and 3-tuple decode - remove .DS_Store, ignore .venv Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Many things updated for my own use, I have got this working quite stably on VESC hardware - unfortunately I no longer have access to that hardware but I'm happy that I got this to a state that it's quite useful.
Allow different send and receive parameters as many commands have different payloads for send receive
Added parameter set and get
Support firmware updates 🎉
Support terminal use
Restructured so that it is a nicer git submodule to fit into a larger project
There are many more things in here, and there are many more improvements that can be made. This is not a perfect PR, but it give much more capability that I hope others find useful.