Adds option to enable/disable infinite scroll

[rodrigo-fm]

Here are a few pictures of the navigation without infinite scroll

And here's a video :)

scroll.mp4

[dessalines]

This seems to be a dupe of nextPage but without pushing to the stack. Why is that necessary?

[dessalines]

Why did this need to change. I thought mutableStateOf only matter for functional components.

[dessalines]

In 1.0, we won't need this stack, as the PagedResponse returns a prev_page and next_page, so please add a TODO comment about that.

[dessalines]

Define this sealed class to help with page types:

sealed class PageType {
    data class Number(val data: Long) : PageType
    data class Cursor(val data: PaginationCursor) : PageType
}

In anticipation of 1.0, provide it with 3 things.

current: PageType?,
nextPage: PageType?,
prevPage: PageType?,

Then do

onNext: (PageType) -> Unit,
onPrev: (PageType) -> Unit,

You can remove onNextEnabled because you'll know this from giving it the nextPage

[dessalines]

You'll now be able to use the correct cursor from the on page button click

[dessalines]

Just show the message for an empty list, which is what's returned by the api anyway. No need for an option.

[rodrigo-fm]

I did this to avoid showing "No more posts available" while loading the posts, I thought this could be seen as a bug by some users. This implementation allowed me to show the "No more posts available" only when the response returns an empty list of posts.

[dessalines]

while loading the posts

The screen above this shouldn't load this component until its ApiState == success, so loading should already be handled. IE the screen should have a ApiState == Loading indicator, that prevents even rendering the PostListings component otherwise.

[rodrigo-fm]

I don't know if I understood it correctly, but the HomeActivity loads the composable like this on the main branch:

val posts: List<PostView> = when (val postsRes = homeViewModel.postsRes) {
    is ApiState.Failure -> {
        apiErrorToast(ctx, postsRes.msg)
        listOf()
    }

    is ApiState.Holder -> {
        postsRes.data
    }

    else -> {
        listOf()
    }
}

The else branch is triggered when postRes is ApiState.Loading, so the message "No more posts available" is displayed while loading because the list is empty. Changing the argument type to List<PostView>? was the easiest way I found to avoid displaying the message while loading the posts.

The CommunityScreen does it differently, though. It only loads the PostListings composable when postRes is ApiState.Holder. I can apply this logic on the HomeActivity, you want it to be like that?

CommunityScreen example:

when (val postsRes = communityViewModel.postsRes) {
  ApiState.Empty -> {
      ApiEmptyText()
  }
  
  is ApiState.Failure -> {
      ApiErrorText(postsRes.msg)
  }
  
  is ApiState.Holder -> { /* load composable */ }

[rodrigo-fm]

Hi, thanks for the comments. I'm currently looking into moving the logic from LookAndFeelScreen to AccountSettings, I currently don't have much time, but I'm trying to code this feature every day, even if it's for a few minutes, so I'll probably take more than a week to catch up with all the changes.

[dessalines]

No problem. Its going to take me a long time to get the 1_0_dev branch up to shape anyway, and that's where I'll probably have to merge this to.

[dessalines]

There are still some unaddressed comments from the last review.

Mark the PR as draft, then ready for review when you're ready for us again.

[dessalines]

This size needs to be defined somewhere, and it should be part of the paginator row margins.

[dessalines]

Pretty sure I have a comment in the last review about renaming this.