Fix mypy errors in reauthenticate() and run lint on dependency bumps - #1010
Merged
Conversation
The mypy 2.3.0 bump (#1006) introduced two errors in wbi_login.py: session.headers.get() returns str | bytes, which is incompatible with the dict[str, str] expected by _perform_login(). Guard the value with an isinstance check before building the headers. The errors went unnoticed because python-lint.yaml only triggers on **.py changes: dependency bumps that touch pyproject.toml/poetry.lock merged without running the linters. Add both files to the workflow paths, matching python-pytest.yaml. Also bump actions/setup-python to v7.0.0 in the lint workflow. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The mypy 2.3.0 bump (#1006) introduced two errors in wbi_login.py: session.headers.get() returns str | bytes, which is incompatible with the dict[str, str] expected by _perform_login(). Guard the value with an isinstance check before building the headers.
The errors went unnoticed because python-lint.yaml only triggers on **.py changes: dependency bumps that touch pyproject.toml/poetry.lock merged without running the linters. Add both files to the workflow paths, matching python-pytest.yaml.
Also bump actions/setup-python to v7.0.0 in the lint workflow.