Mark gopkg.in/yaml.v3 as a direct dependency in go.mod - #99
Merged
Conversation
internal/config imports yaml.v3 directly, but go.mod carried a stale "// indirect" comment. Run `go mod tidy` to correct the require directive and pull in the resulting go.sum entry. Closes #69
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull Request
📖 Description
go.modmarkedgopkg.in/yaml.v3as// indirect, butinternal/configimports itdirectly to parse the application config — the comment was stale. Ran
go mod tidy,which corrects the
requiredirective (drops// indirect) and adds the missinggopkg.in/check.v1hash line togo.sum. Pure hygiene/tooling fix, no behavior change.🎫 Issues
👩💻 Reviewer Notes
Diff is limited to
go.modandgo.sum; nothing else changed. No particular area needsextra scrutiny — just confirm
go build/go vet/tests still pass, which they do.📑 Test Plan
No behavior changed, so no new test was added (see
docs/TESTS.md). Verified locally:go build ./...go vet ./...go test ./... -race -cover— all packages passgolangci-lint run— 0 issues✅ Checklist
General
go test ./... -race -coverpasses locally). (N/A — hygiene-only change, no logic touched)go vet ./...andgolangci-lint runare clean.ARCHITECTURE.mdif this changes a documented design decision. (N/A — no design decision changed)REST API / configuration / packaging
Not applicable — no REST API, configuration, or packaging changes.
⏭ Next Steps
The issue also suggests adding a CI step that fails when
go mod tidyproduces a diff,to prevent this from drifting again. Left as optional follow-up, out of scope for this
minimal fix.