Fix idle session recovery#347
Merged
LargeModGames merged 3 commits intoJul 6, 2026
Merged
Conversation
LargeModGames
approved these changes
Jul 6, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #311
This keeps automatic native idle-session restoration, but limits it to two recovery attempts for the same stale session. After that, background polling stays passive instead of sending
transfer(None)andactivate()every 5-7 seconds while playback is paused or idle.Recovery is enabled again after healthy playback or a new native player session, so startup/device restoration still works without forcing the user to manually select Spotatui.
Testing
cargo fmt --allcargo test idle_cargo test --no-default-features --features telemetrycargo clippy --no-default-features --features telemetry -- -D warningscargo testcargo runAdditional notes
Checked logs after testing. The latest log showed two recovery attempts and then stopped, instead of repeating every 5-7 seconds. Older long-running logs showed hundreds or thousands of repeated attempts.