Issue #1179: Add metric for export types#7765
Merged
Merged
Conversation
XingY
reviewed
Jun 21, 2026
|
|
||
| // This is an approximation of the multi-tab export count. We record an audit log for each tab, and | ||
| // they are all likely to have the same timestamp. Not exact, but perhaps good enough for current purposes. | ||
| sql = new SQLFragment("SELECT COUNT(*) FROM (SELECT *\n" + |
Contributor
There was a problem hiding this comment.
Should we add group by createdby?
Contributor
Author
There was a problem hiding this comment.
Good idea. Done.
| String comment = (String) row.get("Comment"); | ||
| if (comment == null) | ||
| return; | ||
| if (comment.startsWith("Exported to ")) |
Contributor
There was a problem hiding this comment.
Shouldn't this exclude Multi-tab excel export? Or the excel count will be way bloated.
Contributor
Author
There was a problem hiding this comment.
I think it's OK to have the Excel count bloated. This is meant to be a short-lived metric to help us determine if the multi-tab export is in use. The other counts are mostly there just because we can. If we want something more accurate, I think we'd switch this to a client-side count based on menu choices.
I'll let @labkey-hannah weigh in (here or in the issue) if she feels differently.
|
Yea, I'm okay with it being bloated |
XingY
approved these changes
Jun 22, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Rationale
Issue 1179 - Before we make changes to improve the UI for exporting multi-tab Excel files, we want to look at metrics to understand how often this feature is being used. We record and audit log in a dedicated table for each export and can use that to report numbers.
Changes