Kanban Issue 1924: Additional container scoping updates#7753
Merged
Conversation
labkey-susanh
changed the title
labkey-nicka
approved these changes
Jun 16, 2026
| if (provider == null) | ||
| throw new NotFoundException("No provider found for protocol " + form.getProtocolId()); | ||
| // Kanban #1924: Assure permission in the protocol's container, which may be different than the current container | ||
| if (!protocol.getContainer().hasPermission(getUser(), ReadPermission.class)) |
Contributor
There was a problem hiding this comment.
Consider checking for these permissions prior to resolving the assay provider.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Rationale
Small refactors to help introduce better container scoping checks
Related PRs
Changes
OntologyManager.findPropertyUsageswhen given ids to match the behavior when given URIs (that is, to exclude the descriptors not from the given container)