GitHub Issue #1023: Add redirect() helper that uses core-safeRedirect #2021
Open
cnathe wants to merge 7 commits into
Open
GitHub Issue #1023: Add redirect() helper that uses core-safeRedirect #2021cnathe wants to merge 7 commits into
cnathe wants to merge 7 commits into
Conversation
cnathe
commented
Jun 23, 2026
| } | ||
|
|
||
| window.location.href = url.toString(); | ||
| redirect(url.toString()); |
Contributor
Author
There was a problem hiding this comment.
@labkey-alan let me know what you think of this change. This would force the usages of navigate() to be internal redirect/navigations only...but I assume that was the intent and all usages are internal URLs. If there is a need for an external redirect / navigate, it was likely using window.location.href directly, right?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Rationale
https://github.com/LabKey/internal-issues/issues/1023
In the related PR, we added usages of the core-safeRedirect action. This PR moves that into a redirect() helper that can be used instead of setting window.location.href.
Related Pull Requests
Changes