DisplayPeptideGroupInformationAction revert containerId check from previous PR#269
Merged
Conversation
cnathe
requested review from
a team
and removed request for
a team and
labkey-jeckels
Contributor
Author
|
hold off on code review, I have a few more changes for this PR for related issues |
cnathe
commented
Jun 16, 2026
| sql.append(" and peptides.peptide_sequence LIKE ? "); | ||
| sql.add("%" + schema.getSchema().getSqlDialect().encodeLikeOpSearchString(p.getPeptide_sequence()) + "%"); | ||
| sql.append(" and child = false"); | ||
| Peptides[] peptides = new SqlSelector(schema.getSchema(), sql).getArray(Peptides.class); |
Contributor
Author
There was a problem hiding this comment.
FYI, I decided not to add a test case for this change given the low use of this custom module.
labkey-susanh
approved these changes
Jun 16, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Rationale
Related PR made an update for a crawler issue but added an extra containerId check that doesn't apply in this case. Also convert one pepdb manager method to use SQLFragment.
Related Pull Requests