[FluidDynamicsApp][Adjoints] Fluid Adjoints Revamping - #14679
Open
talhah-ansari wants to merge 1 commit into
Open
[FluidDynamicsApp][Adjoints] Fluid Adjoints Revamping#14679talhah-ansari wants to merge 1 commit into
talhah-ansari wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
📝 Description
This PR revamps the fluid elements adjoints developed by @sunethwarna.
The changes focus on cleaning up documentation, improving type safety, correcting naming, and adding missing implementation files. Additionally, the
CalculationContainerTraitsclass is renamed for clarity, and the implementation forQSVMSAdjointElementDatais now provided.This PR is a prerequisite for the next RANSApp adjoints PR.
🆕 Changelog
CalculationContainerTraitstoCalculationDataContainersfor clarity and updated all relevant usages.std::tuple_size_v<T>with the more portablestd::tuple_size<T>::valuein a static assertion.rOutputtorOuputfor consistency.fluid_adjoint_derivatives.handqs_vms_adjoint_element_data.h.qs_vms_adjoint_element_data.cppproviding definitions for static methods inQSVMSAdjointElementData, includingCheck,GetDofVariablesList, andGetIntegrationMethod, as well as template instantiations for supported dimensions and node counts.Check,GetDofVariablesList,GetIntegrationMethod) directly into theQSVMSAdjointElementDataclass, clarifying their usage and encapsulation.All developments are done by Suneth Warnakulasuriya. Thanks @sunethwarna for this work.