chore(localmode): sync compose template with volcano-hosting - #156
Open
tkkhq wants to merge 1 commit into
Open
Conversation
There was a problem hiding this comment.
Pull request overview
Syncs the generated local-mode Compose asset with volcano-hosting to enable v2 agent worker containers.
Changes:
- Mounts the host Docker socket into the server.
- Retains the existing local-storage volume.
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
| # WARNING: This grants the server container permission to run any container | ||
| # with the server's privileges. Only safe in local development on your machine. | ||
| volumes: | ||
| - /var/run/docker.sock:/var/run/docker.sock |
Comment on lines
+76
to
+78
| # Mount docker socket to allow agent worker launch (local mode only). | ||
| # WARNING: This grants the server container permission to run any container | ||
| # with the server's privileges. Only safe in local development on your machine. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Tracking
Summary
Regenerates the embedded local-mode Compose asset from volcano-hosting, so
volcano startproduces a server that can launch a v2 agent worker./var/run/docker.sockmount on theserverservice, which the local-mode server needs to start the agent worker as a sibling containermake volcano-cli-localmode-assets-generatein volcano-hosting; the file is not hand-editedvolcano-hosting owns
infrastructure/local-mode/docker-compose.template.yml. This repository embeds a generated copy so the CLI can start the stack without a hosting checkout. Hosting PR #807 changed the template, which left this copy stale: a developer runningvolcano startgot a server that silently could not launch a worker.The mount is local-mode only. It grants the server container the ability to start containers, which is the local equivalent of the ECS
RunTaskpermission the Fargate launcher holds in cloud.Merge order
Land volcano-hosting PR #807 first, so the source template is final.
Verification
make volcano-cli-localmode-assets-checkin volcano-hosting, pointed at this branch ->volcano-cli local-mode assets check passedgo build ./...-> passgo vet ./...-> passgo test ./... -count=1-> all passgit diff --check-> cleanserverservicevolumesblock; no other service, port, or volume changed