Save simulation config - #141
Open
bnmajor wants to merge 10 commits into
Open
Conversation
bnmajor
force-pushed
the
save-simulation-config
branch
5 times, most recently
from
July 13, 2026 19:06
4284e88 to
7e7ba9e
Compare
Creates the dedicated new_simulation.html partial, the saved simulations listing, the accompanying tests, and routes to render both screens.
Adds the SAVED RunStatus, default updates, and filtering tweaks so saved-only configs don’t show in the analysis sidebar unless requested.
Introduces new edit/run views, URL wiring, and template adjustments so saved runs can be re-used.
- convert to a forms.ModelForm bound to PHOLDSimulationConfig so validators live in a single place - ModelForm._post_clean() now runs full_clean() automatically - run_identifier and stagger remain explicitly declared since they don't map directly to a model field/widget - build the config via form.save(commit=False) instead of manually listing every field
- Rename "Edit" to "Clone" throughout the saved simulations UI since editing a saved config actually creates a new Run/config rather than mutating the original. - Exclude RunStatus.SAVED from the status filter choices on the analysis page - Document the clone-on-edit rationale and the missing source-run linkage as TODOs. - Add TODOs for future pagination on the saved simulations list and replacing the redirect+messages error flow with an inline toast/HTMX notification.
bnmajor
force-pushed
the
save-simulation-config
branch
from
July 14, 2026 22:39
7e7ba9e to
bd5e3f9
Compare
bnmajor
marked this pull request as ready for review
July 14, 2026 22:46
bnmajor
force-pushed
the
save-simulation-config
branch
from
August 4, 2026 19:28
bd5e3f9 to
9adcf72
Compare
bnmajor
requested review from
marySalvi and
waxlamp
and removed request for
marySalvi
August 4, 2026 19:30
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PHOLDSimulationConfigmodel for all PHOLD parametersPHOLDSimulationFormconverted to aModelFormso validators aren't duplicated between form and modelRunStatus.SAVED. A Run now defaults toSAVEDand only moves to PENDING when actually queued