Refactor TorControlPanel for improved security and thread stability#3
Open
sans1924-prog wants to merge 1 commit into
Open
Refactor TorControlPanel for improved security and thread stability#3sans1924-prog wants to merge 1 commit into
sans1924-prog wants to merge 1 commit into
Conversation
This PR introduces targeted security and stability improvements to `tor_control_panel.py` without altering core application logic: * **Thread Stability:** Implemented a `_cleanup_bootstrap_thread` method to gracefully shut down the bootstrap thread. This replaces abrupt `.terminate()` calls, significantly reducing the risk of UI deadlocks and memory leaks during Tor restarts or shutdowns. * **Secure Subprocess Execution:** Replaced the insecure `os.popen` shell execution with a secure `subprocess.Popen` list-based implementation for reading the Tor log. Added proper UTF-8 decoding for robustness. * **Credential Masking:** Added `setEchoMode(QLineEdit.Password)` to the proxy password input field to securely mask user credentials while typing.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR introduces targeted security and stability improvements to
tor_control_panel.pywithout altering core application logic:_cleanup_bootstrap_threadmethod to gracefully shut down the bootstrap thread. This replaces abrupt.terminate()calls, significantly reducing the risk of UI deadlocks and memory leaks during Tor restarts or shutdowns.os.popenshell execution with a securesubprocess.Popenlist-based implementation for reading the Tor log. Added proper UTF-8 decoding for robustness.setEchoMode(QLineEdit.Password)to the proxy password input field to securely mask user credentials while typing.This pull request changes...
Changes
Mandatory Checklist
Terms of Service, Privacy Policy, Cookie Policy, E-Sign Consent, DMCA, Imprint
Optional Checklist
The following items are optional but might be requested in certain cases.
Fixes #