fix out-of-bounds read in windows_read_manifest_from_d3d_adapters#1966
Open
aizu-m wants to merge 1 commit into
Open
fix out-of-bounds read in windows_read_manifest_from_d3d_adapters#1966aizu-m wants to merge 1 commit into
aizu-m wants to merge 1 commit into
Conversation
|
Author aizu-m not on autobuild list. Waiting for curator authorization before starting CI build. |
1 similar comment
|
Author aizu-m not on autobuild list. Waiting for curator authorization before starting CI build. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Was reading why the D3D adapter path converts its registry strings differently to the rest of the loader, which is where this turned up.
Reachable from D3DKMT adapter data during driver and layer discovery. Every other WideCharToMultiByte call in the loader either queries the size first or checks the result. Took the return value as the length and skip the entry when it comes back 0.