fix leaked loader_lock in terminator_CreateHeadlessSurfaceEXT#1956
Merged
Conversation
|
Author aizu-m not on autobuild list. Waiting for curator authorization before starting CI build. |
1 similar comment
|
Author aizu-m not on autobuild list. Waiting for curator authorization before starting CI build. |
|
CI Vulkan-Loader build queued with queue ID 26933. |
charles-lunarg
approved these changes
Jul 3, 2026
charles-lunarg
left a comment
Collaborator
There was a problem hiding this comment.
Yet again, good eye!
|
CI Vulkan-Loader build # 3604 running. |
|
CI Vulkan-Loader build # 3604 passed. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
terminator_CreateHeadlessSurfaceEXT, the disabled-extension branch:Spotted while reading through the surface terminators after the recent DestroySurfaceKHR change. Every other
terminator_Create*Surface*(win32, wayland, xcb, xlib, directfb, macos) reaches its exit throughgoto out, andout:unlocksloader_lock. This one returns straight out with the mutex still held.loader_lockis the loader's global lock. Once it leaks the next entry point that tries to take it blocks forever, so a singlevkCreateHeadlessSurfaceEXTcall made withoutVK_EXT_headless_surfaceenabled wedges the whole instance.Swapped the early
returnforgoto out.resultis alreadyVK_SUCCESSat that point andicd_surfaceis still NULL, socleanup_surface_creationis a no-op and the function returns the same value as before, only now the lock is released. Brings this branch in line with the other create-surface terminators.