fix off-by-one write in loader_platform_executable_path#1954
Merged
Conversation
|
Author aizu-m not on autobuild list. Waiting for curator authorization before starting CI build. |
1 similar comment
|
Author aizu-m not on autobuild list. Waiting for curator authorization before starting CI build. |
|
CI Vulkan-Loader build queued with queue ID 24487. |
charles-lunarg
approved these changes
Jul 1, 2026
|
CI Vulkan-Loader build # 3602 running. |
|
CI Vulkan-Loader build # 3602 passed. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ASAN on a minimal harness of the Linux readlink branch (buffer sized to the caller's 1024):
readlink() never appends a terminator and returns up to
sizebytes. When /proc/self/exe resolves to a path of 1024 bytes or more it returns exactly 1024, andbuffer[count] = '\0'then writes one byte pastcurrent_process_path[1024], the stack arrayget_loader_settingshands in.Found this while diffing the exe-path helpers against each other. The QNX branch already bails on
rdsize == size, and the comment above this function promises a NULL return for over-long paths, but the readlink branch never enforced either. Bail out when count reaches size so the terminator always has room, which also makes the code match its documented behaviour.