JavaRedux: Integer methods + List::remove + NoSuchElementException - #3719
JavaRedux: Integer methods + List::remove + NoSuchElementException#3719FliegendeWurst wants to merge 3 commits into
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #3719 +/- ##
============================================
- Coverage 47.99% 47.98% -0.01%
- Complexity 16046 16059 +13
============================================
Files 1683 1683
Lines 96044 96094 +50
Branches 15387 15394 +7
============================================
+ Hits 46093 46114 +21
- Misses 44681 44713 +32
+ Partials 5270 5267 -3 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
FliegendeWurst
changed the title
|
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #3719 +/- ##
============================================
- Coverage 47.99% 47.98% -0.01%
- Complexity 16046 16059 +13
============================================
Files 1683 1683
Lines 96044 96094 +50
Branches 15387 15394 +7
============================================
+ Hits 46093 46114 +21
- Misses 44681 44713 +32
+ Partials 5270 5267 -3 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
mattulbrich
left a comment
mattulbrich
left a comment
There was a problem hiding this comment.
Thanks! I like the additions, when introducing value in Integer, perhaps be a bit more complete. ...
| /*@ public normal_behavior | ||
| @ ensures \result.value == arg0; | ||
| @ assignable \nothing; | ||
| @*/ | ||
| public static java.lang.Integer valueOf(int arg0); | ||
| public Integer(int arg0); |
There was a problem hiding this comment.
should there not also be an assignment to value or at least a contract with the effect in the constructor?
Similar to the static method above.
| /*@ public normal_behavior | ||
| @ ensures \result == value; | ||
| @ assignable \strictly_nothing; | ||
| @*/ | ||
| public int intValue(); | ||
| public long longValue(); |
There was a problem hiding this comment.
at least the long conversion can be formulated in JML too.
3 participants
Intended Change
The
Integerclass is a bit useless without providing at leastvalueOfandintValue, so I added specifications for those methods. And the fieldvalueto store the int value.The
List::removemethod to remove elements by index is useful to have.The
NoSuchElementExceptionclass is required to implement iterators.Type of pull request
Ensuring quality
Additional information and contact(s)
The contributions within this pull request are licensed under GPLv2 (only) for inclusion in KeY.