read_trial_domains_to_json.sas runs unmodified on Jenner — test bundle - #1
Open
jenner-analytics wants to merge 1 commit into
Open
Conversation
- t001_ts_recode: the Trial Summary (TS) recode DATA step from scripts/read_trial_domains_to_json.sas, against a small mock TS domain. - t002_xport_roundtrip: the XPORT + PROC COPY read path of %download_and_convert_xpt, against a locally written v5 transport file. Each bundle carries a captured passing run (expected.json + expected/) and run_jenner.sh re-runs and verifies them against api.jenneranalytics.com.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Jenneranalytics.com provides an API that runs SAS code, with support for more than 200 SAS procedures. You can also use it with AI assistants in a collaborative workspace. It's available for Mac on the Apple App Store, and by license for Windows and Linux.
We support the larger community by
(1) increasing access to SAS-compatible systems,
(2) by providing test coverage and a test coverage framework to public SAS repos in order to encourage the use of best practices in software engineering.
Your read_trial_domains_to_json.sas runs on Jenner unmodified — this PR adds a small compatibility bundle so you can see for yourself. It's the test we wrote for your project, shared in case it's useful, and was assembled with AI assistance as is most code in modern businesses today.
What stood out reading the script is how
%create_jsonstays data-driven: a space-delimiteddatasets=list walked with%SCANover%COUNTW, driving onePROC JSONEXPORTper domain into a single output file. Adding or dropping a Trial Design domain becomes a one-word edit rather than a code change, and that same list threads straight through%download_and_convert_xptfor the download side. The honest* coding issue is available which needs to be fixed;note above the TS patch is the kind of comment that makes a repo easy to trust.The
jenner-check/directory holds two self-contained bundles built from that script — a copy of the SAS, the captured output of the run, and a small shell runner. Nothing outsidejenner-check/is touched, nothing runs on merge, and there are no workflow files or hooks.To try one against the hosted API, check out this PR and run from the repo root:
# gh pr checkout 1 puts you on this branch; then from the repo root: curl -sS --data-binary @jenner-check/t001_ts_recode/script.sas https://api.jenneranalytics.com/v1/quickOr
cd jenner-check && ./run_jenner.sh --allre-runs every bundle and checks each against its captured result. It's free to try, no signup — full API reference: the docs.On what leaves your machine: the runner uploads only the SAS source text of the script it runs (plus a two-line autoexec) to api.jenneranalytics.com, which runs it and returns the log and listing. It does not read or upload any data files, so anything sitting next to a script stays on your machine, and nothing is sent unless you run one of these commands yourself — the same as pasting a snippet into any hosted tool. Since it's a script's own source that gets sent, you can review it first if one ever embeds a value inline.
Merge it, close it, or ignore it — all fine, and no response is expected. We won't open further PRs here. To opt out for good, put
no-more-prsin any comment or open an issue titledjenner-check: opt out.Lawrence W. Sinclair
CEO / Jenner Analytics Ltd
linkedin.com/in/lwsinclair/